Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenAI: Use common env var for content recording #2947

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Nov 4, 2024

Based on the discussion in GenAI SIG, changing the env var name to a generic one (so that users can configure content capturing in the same way for all genai instrumentations).

- OTEL_INSTRUMENTATION_OPENAI_CAPTURE_MESSAGE_CONTENT
+ OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT

This has never been released, so it's not breaking.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@lzchen lzchen merged commit 155962b into open-telemetry:main Nov 4, 2024
536 checks passed
@lmolkova lmolkova deleted the rename-openai-env-var-to-genai branch November 7, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants