fix: remove opentelemetry-instrumentation-test package from bootstrap_gen #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
|
Please consider adding a version specifier to first instead of removing opentelemetry-instrumentation-test package. |
|
Should this be listed as breaking change and write to remove that package to avoid conflicts in CHANGELOG? |
To not mix different things I prefer to fix sqlalchemy issue in another PR. |
emdneto
changed the title
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
xrmx
approved these changes
Nov 7, 2024
tammy-baylis-swi
approved these changes
Nov 7, 2024
lzchen
approved these changes
Nov 7, 2024
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
lzchen
pushed a commit
that referenced
this pull request
Nov 7, 2024
lmolkova
pushed a commit
to lmolkova/opentelemetry-python-contrib
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2968