-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Async
openai instrumentation
#2984
Merged
lzchen
merged 23 commits into
open-telemetry:main
from
alizenhom:support-async-openai-instrumentation
Nov 14, 2024
Merged
Add Support for Async
openai instrumentation
#2984
lzchen
merged 23 commits into
open-telemetry:main
from
alizenhom:support-async-openai-instrumentation
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned alizenhom, gyliu513, karthikscale3, lmolkova, lzchen and nirga
Nov 8, 2024
github-actions
bot
requested review from
gyliu513,
karthikscale3,
lmolkova,
lzchen and
nirga
November 8, 2024 13:06
xrmx
reviewed
Nov 8, 2024
.../opentelemetry-instrumentation-openai-v2/tests/cassettes/test_async_chat_completion_404.yaml
Outdated
Show resolved
Hide resolved
gyliu513
reviewed
Nov 8, 2024
...ntelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/__init__.py
Show resolved
Hide resolved
alizenhom
force-pushed
the
support-async-openai-instrumentation
branch
from
November 9, 2024 12:05
d3f2ad9
to
0dacda8
Compare
codefromthecrypt
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(non-binding approve)
Looks good with a suggestion on changelog, and assuming the recordings are corrected to the formatting of the others.
instrumentation-genai/opentelemetry-instrumentation-openai-v2/CHANGELOG.md
Outdated
Show resolved
Hide resolved
codefromthecrypt
added a commit
to codefromthecrypt/opentelemetry-python-contrib
that referenced
this pull request
Nov 11, 2024
… yaml fixture Follow-up to open-telemetry#2945 See open-telemetry#2984 (comment) Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
12 tasks
….com/alizenhom/opentelemetry-python-contrib into support-async-openai-instrumentation
/lgtm |
12 tasks
...trumentation-openai-v2/tests/cassettes/test_async_chat_completion_tool_calls_no_content.yaml
Show resolved
Hide resolved
…y-python-contrib into support-async-openai-instrumentation
…y-python-contrib into support-async-openai-instrumentation
codefromthecrypt
approved these changes
Nov 13, 2024
lzchen
reviewed
Nov 13, 2024
instrumentation-genai/opentelemetry-instrumentation-openai-v2/CHANGELOG.md
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Nov 13, 2024
xrmx
approved these changes
Nov 14, 2024
karthikscale3
approved these changes
Nov 14, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AsyncCompletions.create
to instrument async openai functionsStreamWrapper
to include__anext__
,__aiter__
&__aenter__
Type of change
How Has This Been Tested?
tox -e py312-test-instrumentation-openai-v2-0
tox -e py312-test-instrumentation-openai-v2-1
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.