opentelemetry-instrumentation-httpx: make instrument_client a staticmethod again #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi
approved these changes
Nov 14, 2024
emdneto
approved these changes
Nov 14, 2024
lzchen
approved these changes
Nov 14, 2024
aabmass
approved these changes
Nov 14, 2024
...tion/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py
Outdated
Show resolved
Hide resolved
xrmx
force-pushed
the
httpx-static-regression
branch
from
2643507 to
19898df
Compare
11 tasks
6 tasks
aabmass
pushed a commit
to aabmass/opentelemetry-python-contrib
that referenced
this pull request
Nov 15, 2024
…ethod again (open-telemetry#3003) * opentelemetry-instrumentation-httpx: make instrument_client a staticmethod again * ADd changelog * Can be a classmethod --------- Co-authored-by: Leighton Chen <lechen@microsoft.com>
aabmass
added a commit
that referenced
this pull request
Nov 15, 2024
…strument_client a staticmethod again (#3003) (#3008) * opentelemetry-instrumentation-httpx: make instrument_client a staticmethod again (#3003) * opentelemetry-instrumentation-httpx: make instrument_client a staticmethod again * ADd changelog * Can be a classmethod --------- Co-authored-by: Leighton Chen <lechen@microsoft.com> * Move changelog entry to Unreleased section --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Co-authored-by: Leighton Chen <lechen@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2998
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.