Sync with Make setters and getters optional #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
force-pushed
the
issue_371
branch
10 times, most recently
from
e2214f2 to
9e6481f
Compare
ocelotl
requested review from
a team,
codeboten and
aabmass
and removed request for
a team
11 tasks
ocelotl
force-pushed
the
issue_371
branch
3 times, most recently
from
a1bda20 to
f3d5897
Compare
6 tasks
Fixes #issue_371
This reverts commit f3d5897.
codeboten
reviewed
Mar 25, 2021
propagator/opentelemetry-propagator-ot-trace/src/opentelemetry/propagators/ot_trace/__init__.py
Outdated
Show resolved
Hide resolved
...y-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/trace/propagation/aws_xray_format.py
Outdated
Show resolved
Hide resolved
sdk-extension/opentelemetry-sdk-extension-aws/tests/trace/propagation/test_aws_xray_format.py
Outdated
Show resolved
Hide resolved
ocelotl
changed the title
codeboten
reviewed
Mar 26, 2021
codeboten
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #372
Description
Removes setters and getters from contribs.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.