Move instrumentation aiohttp client #49
Conversation
`README.md` and the opentelemetry website say this library is in beta, and releases have been called betas since March, so update `docs/index.rst` to be consistent with that.
* updating changelogs and version to 0.13b0
| long_description_content_type = text/x-rst | ||
| author = OpenTelemetry Authors | ||
| author_email = cncf-opentelemetry-contributors@lists.cncf.io | ||
| url = https://github.com/open-telemetry/opentelemetry-python/instrumentation/opentelemetry-instrumentation-aiohttp-client |
There was a problem hiding this comment.
@codeboten It just occurred to me that this url is out of date. Should we wait to merge in all the PRs and update all these links at the same time? Or would you prefer I make commits on all the PRs to update the links individually?
I would prefer the one commit to change all the links at the end but let me know what you think.
There was a problem hiding this comment.
Updating them all at once makes sense to me
| =src | ||
| packages=find_namespace: | ||
| install_requires = | ||
| opentelemetry-api == 0.15.dev0 |
There was a problem hiding this comment.
should this be updated to the latest released version here?
There was a problem hiding this comment.
Yes it should! This is to make sure we take in the latest from the Core master and not lose any work already merged into the Core repo.
The blame shows it was merged into Core on this commit:
Description
Moves the
instrumentation/opentelemetry-instrumentation-aiohttp-clientfrom the core repo into the contrib repo.The original code is being copied over from the Core repo here: https://github.com/open-telemetry/opentelemetry-python/tree/master/instrumentation/opentelemetry-instrumentation-aiohttp-client
How Has This Been Tested?
CI tests will confirm it works correctly.
The only reason I didn't add tests yet (and I didn't plan to until we get all the packages we want in) is because the tests introduced here depend on other packages that will be coming (very soon hopefully!) in future PRs.
For example the files in this PR have these import statements:
Both of which don't exist yet in this repo until I add them, in future PRs.
After the PRs with the packages are merged, I'll create a final PR to add tests. (And I count on it working based on my big #47 PR)
Checklist:
- [ ] Changelogs have been updated- [ ] Unit tests have been added- [ ] Documentation has been updated