Reorder on_finish call order to correctly instrument all tornado work done during a request #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitabwire
requested review from
a team,
codeboten and
ocelotl
and removed request for
a team
|
|
codeboten
reviewed
May 25, 2021
There was a problem hiding this comment.
Hey @pitabwire, thanks for the PR. Is it possible to add a test to capture the issue being fixed here?
Also please add an entry to CHANGELOG.md.
ocelotl
suggested changes
May 26, 2021
There was a problem hiding this comment.
Neat 😎
Yes, please add a test, as requested by @codeboten ✌️
owais
approved these changes
Jun 1, 2021
lzchen
approved these changes
Jun 4, 2021
|
@pitabwire |
codeboten
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures trace processing is closed only after tornado's on_finish method is called
Fixes #495
Type of change