Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the psycopg2 dependency #543

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Update the psycopg2 dependency #543

merged 4 commits into from
Jun 22, 2021

Conversation

RyanSiu1995
Copy link
Contributor

@RyanSiu1995 RyanSiu1995 commented Jun 15, 2021 •
edited
Loading

Description

Fixes #541

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@RyanSiu1995 RyanSiu1995 requested review from a team, owais and lzchen and removed request for a team June 15, 2021 06:23
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 15, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@RyanSiu1995
Copy link
Contributor Author

Trying to fix the docker-tests right now

@RyanSiu1995
Copy link
Contributor Author

I have tested it locally with tox -e docker-tests.
And the failed tests have all passed after changing the dependency inside tox.ini

@RyanSiu1995 RyanSiu1995 requested review from owais and codeboten June 19, 2021 13:55
@RyanSiu1995
Copy link
Contributor Author

Hi @owais and @codeboten, could you mind helping me to re-review this?

@codeboten codeboten merged commit 63e7561 into open-telemetry:main Jun 22, 2021
@cdvv7788
Copy link
Contributor

Nice! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owais owais owais approved these changes

@lzchen lzchen Awaiting requested review from lzchen

@codeboten codeboten Awaiting requested review from codeboten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

psycopg2-binary dependency conflict
4 participants
@RyanSiu1995 @cdvv7788 @owais @codeboten