-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Falcon instrumentation compatible with Falcon >=3 #607
Conversation
Replace falcon.api.Request -> falcon.Request which exists on both Falcon 2 & 3
Thanks @owais . CLA link is giving me a 500, I opened a support ticket. I edited the package and changelog. Will updating the package also run tests on 3.0? |
No. You'll need to update the test matrix in tox.ini to do that. |
It is triggered automatically on every push. Looks like the falcon tests are failing. |
Not if you're a first time contributor:
I reverted the changes to I'd appreciate a bit more hands-on support here, the interdependency between the otel packages (api, sdk, core, contrib, etc.) and the packaging of the repo (monorepo, tox, etc.) compounded with broken contributing instructions make it a bit confusing for a first time contributor. It's taking a lot more work than I'd like to contribute a 1 line fix. |
@owais I saw you self assigned this. Will you be taking it over? I don't want us to duplicate work offline 😄 |
@adriangb No, a PR assignee represents someone who has taken up the responsibility to review a PR and see it through. I don't intent to work on it :) |
Got it, thanks for clarifying. I'm going to pick this up again this week. It does look like there's still some infrastructure / CI issues: I'm seeing failures in Celary tests and Linting timing out, which certainly aren't related to this change. |
We should update tox.ini to test multiple versions but not a blocker for me rigth now. |
Yep I was just waiting to see if the current failures would resolve before changing more stuff. Looks like the last run passed, so I'll try to put this change in again. |
Replace falcon.api.Request -> falcon.Request which exists on both Falcon 2 & 3
Steps to reproduce:
pip install falcon==3.0.0
You'll get:
And I verified that in Falcon >=3
falcon.api
does not exit.Also to note,
falcon.API
is being deprecated in favor offalcon.App
. Not sure how you want to handle that. I reckon some version checks will be needed to support both Falcon 2 & 4.