Support PyMySQL 1.x series #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
pymysql-dep-update
branch
2 times, most recently
from
d7ec723 to
8ea7c3e
Compare
owais
force-pushed
the
pymysql-dep-update
branch
from
8ea7c3e to
3498e8f
Compare
owais
commented
Nov 5, 2021
| @@ -462,7 +462,7 @@ deps = | |||
| psycopg2 ~= 2.8.4 | |||
| aiopg >= 0.13.0, < 1.3.0 | |||
| sqlalchemy ~= 1.4 | |||
| redis ~= 3.3.11 | |||
| redis ~= 3.5 | |||
There was a problem hiding this comment.
celery tests are failing with redis 3.3 so had to upgrade
There was a problem hiding this comment.
curious , why did celery tests fail with redis 3.3?
There was a problem hiding this comment.
We pinned redis but did not pin celery. Latest version of celery/kombu passes extra params to redis which 3.3.x did not accept.
srikanthccv
approved these changes
Nov 6, 2021
| @@ -462,7 +462,7 @@ deps = | |||
| psycopg2 ~= 2.8.4 | |||
| aiopg >= 0.13.0, < 1.3.0 | |||
| sqlalchemy ~= 1.4 | |||
| redis ~= 3.3.11 | |||
| redis ~= 3.5 | |||
There was a problem hiding this comment.
curious , why did celery tests fail with redis 3.3?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #791
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.