aiohttp instrumentation: correct url filter input type #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
reviewed
Jan 16, 2022
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Show resolved
Hide resolved
lzchen
approved these changes
Jan 18, 2022
owais
approved these changes
Jan 26, 2022
|
@Olegt0rr please resolve conflicts and make sure CI checks pass. |
|
@owais, something wrong with EasyCLA, cause after clicking on "Please click here to be authorized" and make a sign, EasyCLA redirects me to PR 857 |
owais
approved these changes
Feb 1, 2022
|
@owais, |
|
Look at the docs tox job in tox.ini. My guess is that you might have to add yarl as an explicit dependency to that job. |
auto-merge was automatically disabled
February 1, 2022 20:13
Head branch was pushed to by a user without write access
ocelotl
suggested changes
Feb 1, 2022
This reverts commit e482ba5.
ocelotl
approved these changes
Feb 1, 2022
ashu658
pushed a commit
to ashu658/opentelemetry-python-contrib
that referenced
this pull request
Feb 2, 2022
…y#864) * fix: correct _UrlFilterT * docs: CHANGELOG.md update * style: apply isort * fix: add yarl to docs requirements * Revert "fix: add yarl to docs requirements" This reverts commit e482ba5. * fix: add yarl to nitpick exceptions Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Url filter function receives
yarl.URLtype, as described in the documentation.But
_UrlFilterTtype describesstrinput... We need to fix itType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.