Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datadog-apm: deprecate datadog exporter #900

Merged

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Feb 3, 2022

Description

Adds deprecation note to the Datadog Span Exporter.

Type of change

Updates Readme

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

N/A

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@mabdinur mabdinur force-pushed the munir/deprecate-otel-datadog-exporter branch from 0876183 to e18fe73 Compare February 3, 2022 19:56
@mabdinur mabdinur changed the title chore!: deprecate datadog exporter datadog-apm: deprecate datadog exporter Mar 9, 2022
@mabdinur mabdinur force-pushed the munir/deprecate-otel-datadog-exporter branch from a5f6ec9 to e1811c3 Compare March 9, 2022 20:42
@mabdinur mabdinur force-pushed the munir/deprecate-otel-datadog-exporter branch from e1811c3 to 91cb890 Compare March 9, 2022 20:48
@mabdinur mabdinur marked this pull request as ready for review March 9, 2022 20:48
@mabdinur mabdinur requested a review from a team March 9, 2022 20:48
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging @majorgreys as the original author

exporter/opentelemetry-exporter-datadog/README.rst Outdated Show resolved Hide resolved
@brettlangdon
Copy link
Contributor

Once this PR is approved/merged is it possible to update the PyPI description for this package?

@codeboten
Copy link
Contributor

Once this PR is approved/merged is it possible to update the PyPI description for this package?

The pypi documentation will be updated when the next release of the package goes out.

@brettlangdon
Copy link
Contributor

The pypi documentation will be updated when the next release of the package goes out.

Yeah, my thoughts are if we don't do another release, could still be nice to update the notes.

Or maybe the right way is to do a new release even without code changes because we are marking the package as deprecated ?

Co-authored-by: Alex Boten <alex@boten.ca>
@mabdinur mabdinur force-pushed the munir/deprecate-otel-datadog-exporter branch from 9526aca to 77f6c18 Compare March 10, 2022 15:00
@mabdinur mabdinur requested a review from codeboten March 10, 2022 15:37
@lzchen lzchen merged commit 1bf9e0c into open-telemetry:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants