feat(instrumentation-dbapi): add experimental sql commenter capability #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
reviewed
Feb 9, 2022
| _KEY_VALUE_DELIMITER = "," | ||
|
|
||
|
|
||
| def _generate_sql_comment(**meta): |
There was a problem hiding this comment.
Is it really necessary to add this to utils? This is a single-use function, its contents can just be used directly where the function is called.
There was a problem hiding this comment.
I think so, there will be many sql db instrumentations that will rely on this.
| @@ -115,3 +116,38 @@ def _start_internal_or_server_span( | |||
| attributes=attributes, | |||
| ) | |||
| return span, token | |||
|
|
|||
|
|
|||
| _KEY_VALUE_DELIMITER = "," | |||
...tion/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py
Outdated
Show resolved
Hide resolved
…lemetry/instrumentation/dbapi/__init__.py Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
ocelotl
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for an experimental and optional feature for enabling sql commenter capability to dbapi instrumentation.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e test-instrumentation-dbapiDoes This PR Require a Core Repo Change?