Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing build failures #928

Merged
merged 6 commits into from
Mar 1, 2022
Merged

Fixing build failures #928

merged 6 commits into from
Mar 1, 2022

Conversation

ashu658
Copy link
Member

@ashu658 ashu658 commented Feb 25, 2022 •
edited
Loading

Description

Generate and Contrib Repo Tests (py310, instrumentation) are failing for #925 due to

  1. breaking change in markupsafe ImportError: cannot import name 'soft_unicode' from 'markupsafe'  pallets/markupsafe#282 and
  2. breaking change in itsdangerous ImportError: cannot import name 'json' from 'itsdangerous' pallets/itsdangerous#289

Pinning markupsafe version to 2.0.1 and itsdangerous version to 2.0.1 to fix the issue.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project

@ashu658 ashu658 requested a review from a team February 25, 2022 08:47
@ashu658 ashu658 changed the title Upgrading jinja2 to fix build failures [WIP] Upgrading jinja2 to fix build failures Feb 25, 2022
@ashu658 ashu658 marked this pull request as draft February 25, 2022 10:36
codeboten
codeboten reviewed Feb 25, 2022
View reviewed changes
dev-requirements.txt Outdated Show resolved Hide resolved
@ashu658 ashu658 changed the title [WIP] Upgrading jinja2 to fix build failures [WIP] Fixing build failures Feb 28, 2022
@srikanthccv
Copy link
Member

@ashu658 We also need to pin version in docs-requirements.txt, instrumentation-boto, instrumentation-botocore, instrumentation-flask, instrumentation-jinja2. It would be great if you get that done and mark this ready for review :).

@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 1, 2022
@ashu658 ashu658 changed the title [WIP] Fixing build failures Fixing build failures Mar 1, 2022
@ashu658 ashu658 marked this pull request as ready for review March 1, 2022 13:10
srikanthccv
srikanthccv approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@ashu658
Copy link
Member Author

ashu658 commented Mar 1, 2022

Thank you!!

My pleasure :)

@lzchen lzchen merged commit ca5a4a1 into open-telemetry:main Mar 1, 2022
@ashu658 ashu658 mentioned this pull request Mar 8, 2022
Closed
6 tasks
@ashu658 ashu658 mentioned this pull request Apr 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@srikanthccv srikanthccv srikanthccv approved these changes

@lzchen lzchen lzchen approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashu658 @srikanthccv @codeboten @lzchen