Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make requests span attributes available to samplers #931

Merged
merged 3 commits into from
Mar 4, 2022

Conversation

trask
Copy link
Member

@trask trask commented Feb 27, 2022

Description

Updates requests instrumentation based on http semantic conventions:

Following attributes MUST be provided at span creation time (when provided at all), so they can be considered for sampling decisions:

  • http.method
  • http.url
  • ...

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • requests instrumentation tests were run

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@trask trask force-pushed the requests-span-attributes branch from ceb8801 to 1319498 Compare February 27, 2022 03:43
@trask trask marked this pull request as ready for review February 28, 2022 21:30
@trask trask requested a review from a team February 28, 2022 21:30
@lzchen lzchen merged commit 2ab6641 into open-telemetry:main Mar 4, 2022
@trask trask deleted the requests-span-attributes branch March 4, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants