Skip to content

Commit

Permalink
Fix SDK
Browse files Browse the repository at this point in the history
  • Loading branch information
ocelotl committed Dec 6, 2022
1 parent 6ea68b7 commit 6a5709d
Show file tree
Hide file tree
Showing 11 changed files with 35 additions and 200 deletions.
2 changes: 1 addition & 1 deletion opentelemetry-api/src/opentelemetry/context/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
from functools import wraps
from os import environ
from sys import version_info
from opentelemetry.util._entry_points import entry_points

# pylint: disable=wrong-import-position
from opentelemetry.context.context import Context
from opentelemetry.environment_variables import OTEL_PYTHON_CONTEXT
from opentelemetry.util._entry_points import entry_points

logger = logging.getLogger(__name__)
_RUNTIME_CONTEXT = None # type: typing.Optional[_RuntimeContext]
Expand Down
1 change: 0 additions & 1 deletion opentelemetry-api/src/opentelemetry/propagate/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ def example_route():
from opentelemetry.propagators import composite, textmap
from opentelemetry.util._entry_points import entry_points


logger = getLogger(__name__)


Expand Down
6 changes: 3 additions & 3 deletions opentelemetry-api/src/opentelemetry/util/_entry_points.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
# FIXME remove this file when support for 3.7 is dropped.
if version_info.minor == 7:
# pylint: disable=import-error
from importlib_metadata import entry_points # type: ignore
from importlib_metadata import entry_points, version # type: ignore
else:
from importlib.metadata import entry_points
from importlib.metadata import entry_points, version

__all__ = ["entry_points"]
__all__ = ["entry_points", "version"]
1 change: 1 addition & 0 deletions opentelemetry-api/src/opentelemetry/util/_providers.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from os import environ
from sys import version_info
from typing import TYPE_CHECKING, TypeVar, cast

from opentelemetry.util._entry_points import entry_points

if TYPE_CHECKING:
Expand Down
1 change: 0 additions & 1 deletion opentelemetry-api/tests/util/test__providers.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@


class Test_Providers(TestCase):

@patch.dict(
environ,
{ # type: ignore
Expand Down
4 changes: 3 additions & 1 deletion opentelemetry-api/tests/util/test_re.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ def test_parse_env_headers(self):
headers, expected, warn = case_
if warn:
with self.assertLogs(level="WARNING") as cm:
self.assertEqual(parse_env_headers(headers), dict(expected))
self.assertEqual(
parse_env_headers(headers), dict(expected)
)
self.assertTrue(
"Header format invalid! Header values in environment "
"variables must be URL encoded per the OpenTelemetry "
Expand Down
33 changes: 9 additions & 24 deletions opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,7 @@
from opentelemetry.sdk.trace.sampling import Sampler
from opentelemetry.semconv.resource import ResourceAttributes
from opentelemetry.trace import set_tracer_provider

# FIXME remove when support for 3.7 is dropped.
if version_info.minor == 7:
# pylint: disable=import-error
from importlib_metadata import entry_points
else:
from importlib.metadata import entry_points
from opentelemetry.util._entry_points import entry_points

_EXPORTER_OTLP = "otlp"
_EXPORTER_OTLP_PROTO_GRPC = "otlp_proto_grpc"
Expand Down Expand Up @@ -100,21 +94,8 @@ def _import_config_components(

component_implementations = []

# FIXME remove when support for 3.7 is dropped.
if version_info.minor == 7:

for entry_point in entry_points():
for selected_component in selected_components:
if (
entry_point.name == selected_component
and entry_point.group == entry_point_name
):
component_implementations.append(
(selected_component, entry_point.load())
)

# FIXME remove when support for 3.9 is dropped.
elif version_info.minor <= 9:
if version_info.minor in (8, 9):

for entry_point in entry_points()[entry_point_name]:
for selected_component in selected_components:
Expand All @@ -128,9 +109,13 @@ def _import_config_components(
component_implementations.append(
(
selected_component,
entry_points(
group=entry_point_name, name=selected_component
)[0].load(),
next(
iter(
entry_points(
group=entry_point_name, name=selected_component
)
)
).load(),
)
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,7 @@ def _handle(self, error: Exception, *args, **kwargs):
from logging import getLogger
from sys import version_info

# FIXME remove when support for 3.7 is dropped.
if version_info.minor == 7:
# pylint: disable=import-error
from importlib_metadata import entry_points
else:
from importlib.metadata import entry_points
from opentelemetry.util._entry_points import entry_points

logger = getLogger(__name__)

Expand Down Expand Up @@ -125,7 +120,7 @@ def __exit__(self, exc_type, exc_value, traceback):
plugin_handled = False

# FIXME remove when support for 3.9 is dropped.
if version_info.minor <= 9:
if version_info.minor in (8, 9):

error_handler_entry_points = entry_points()[
"opentelemetry_error_handler"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,23 +63,16 @@
import typing
from json import dumps
from urllib import parse
from sys import version_info

from opentelemetry.attributes import BoundedAttributes
from opentelemetry.sdk.environment_variables import (
OTEL_RESOURCE_ATTRIBUTES,
OTEL_SERVICE_NAME,
)
from opentelemetry.semconv.resource import ResourceAttributes
from opentelemetry.util._entry_points import version
from opentelemetry.util.types import AttributeValue

# FIXME remove when support for 3.7 is dropped.
if version_info.minor == 7:
# pylint: disable=import-error
from importlib_metadata import version
else:
from importlib.metadata import version

LabelValue = AttributeValue
Attributes = typing.Dict[str, LabelValue]
logger = logging.getLogger(__name__)
Expand Down
6 changes: 3 additions & 3 deletions opentelemetry-sdk/tests/error_handler/test_error_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class AssertionErrorHandler(ErrorHandler, AssertionError):
)

# FIXME remove when support for 3.9 is dropped.
if version_info.minor <= 9:
if version_info.minor in (8, 9):

mock_entry_points.configure_mock(
**{
Expand Down Expand Up @@ -109,7 +109,7 @@ def _handle(self, error: Exception):
)

# FIXME remove when support for 3.9 is dropped.
if version_info.minor <= 9:
if version_info.minor in (8, 9):

mock_entry_points.configure_mock(
**{
Expand Down Expand Up @@ -149,7 +149,7 @@ def __new__(cls):
)

# FIXME remove when support for 3.9 is dropped.
if version_info.minor <= 9:
if version_info.minor in (8, 9):

mock_entry_points.configure_mock(
**{
Expand Down
Loading

0 comments on commit 6a5709d

Please sign in to comment.