Skip to content

Commit

Permalink
refactor(otlp exporter): refactor client certificate and key handling
Browse files Browse the repository at this point in the history
- Moved `client_key_file` and `client_certificate_file` to local variables as suggested.
- Added a comment explaining the retention of these as instance variables for testing purposes.
- Addressed all review comments to improve code readability and maintainability.
  • Loading branch information
sandy2008 committed Aug 14, 2024
1 parent 1e3ed88 commit 92ebea0
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,9 @@ def _get_file_content(file_path: str) -> bytes:


def _load_credentials(
certificate_file: Optional[str],
client_key_file: Optional[str],
client_certificate_file: Optional[str],
certificate_file: str,
client_key_file: str,
client_certificate_file: str,
) -> Optional[ChannelCredentials]:
try:
root_certificates = _get_file_content(certificate_file)
Expand Down

0 comments on commit 92ebea0

Please sign in to comment.