-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Iterator[Span]
return type annotations
#219
Comments
I started looking into this - however, even changing the signature to __init__.py:243: error: "bool" is invalid as return type for "__exit__" that always returns False
__init__.py:243: note: Use "typing_extensions.Literal[False]" as the return type or change it to "None" There's also the question of how to handle the version check for |
(that is, opposed to simply doing a |
I think the rain of errors ⛈ was fixed in #229. But about the try/except ImportError: I thought that was a common idiom in Python, e.g. for 2/3 compatibility? |
I noticed this was still assigned to me -- unassigned, as I don't actually have this on my TODO list. |
Closing for now due to inactivity. |
From #198 (comment)
A unit test should be added to the API package that verifies one can properly use the Spans returned by various APIs as
Iterator[Span]
without mypy complaining.The text was updated successfully, but these errors were encountered: