Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement baggage support in the OT shim #239

Closed
johananl opened this issue Oct 25, 2019 · 1 comment · Fixed by #912
Closed

Implement baggage support in the OT shim #239

johananl opened this issue Oct 25, 2019 · 1 comment · Fixed by #912
Assignees
Labels
shim OpenTracing or OpenCensus compatibility tracing

Comments

@johananl
Copy link
Contributor

We should implement baggage support in the OT shim:

@property
def baggage(self):
logger.warning(
"Using unimplemented property baggage on class %s.",
self.__class__.__name__,
)
# TODO: Implement.

def set_baggage_item(self, key, value):
logger.warning(
"Calling unimplemented method set_baggage_item() on class %s",
self.__class__.__name__,
)
# TODO: Implement.
def get_baggage_item(self, key):
logger.warning(
"Calling unimplemented method get_baggage_item() on class %s",
self.__class__.__name__,
)
# TODO: Implement.

@Oberon00 Oberon00 added shim OpenTracing or OpenCensus compatibility tracing labels Oct 28, 2019
@c24t c24t added this to the Alpha v0.4 milestone Oct 31, 2019
@c24t
Copy link
Member

c24t commented Jan 16, 2020

FYI changes to the context API in #325 will likely affect this. You may want to wait until that PR is merged to tackle this one.

@c24t c24t removed this from the Alpha v0.4 milestone Jan 16, 2020
@ocelotl ocelotl self-assigned this Jul 11, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 14, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 17, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 20, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 22, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 22, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 22, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 22, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 31, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 31, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 31, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 31, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 5, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 5, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 5, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 5, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 5, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 5, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 5, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 6, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 6, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 6, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 6, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 6, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 6, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 6, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 6, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 6, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shim OpenTracing or OpenCensus compatibility tracing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants