Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing ABC for Metric #390

Closed
GoPavel opened this issue Jan 30, 2020 · 2 comments · Fixed by #391
Closed

Missing ABC for Metric #390

GoPavel opened this issue Jan 30, 2020 · 2 comments · Fixed by #391
Labels
bug Something isn't working good first issue Good first issue help wanted

Comments

@GoPavel
Copy link
Contributor

GoPavel commented Jan 30, 2020

Missing ABC for Metric seems strange to me.
I guess in the PR #311 and Issue #66 settle to add ABC for all interfaces.

Maybe it should look like:

class Metric(abc.ABC):
    """...
    """

    @abc.abstractmethod
    def get_handle(self, label_set: LabelSet) -> "object":
        """...
        """
@GoPavel GoPavel added the bug Something isn't working label Jan 30, 2020
@codeboten
Copy link
Contributor

Thanks for catching this. Mind submitting a PR @GoPavel since you already have most of the code written up here?

GoPavel added a commit to GoPavel/opentelemetry-python that referenced this issue Jan 31, 2020
@GoPavel
Add missing ABC for Metric
bab7d57 
Fix open-telemetry#390
@GoPavel GoPavel mentioned this issue Jan 31, 2020
Merged
@GoPavel
Copy link
Contributor Author

GoPavel commented Jan 31, 2020 •
edited
Loading

Thanks for catching this. Mind submitting a PR @GoPavel since you already have most of the code written up here?

Ok. Could you review it?

toumorokoshi pushed a commit that referenced this issue Jan 31, 2020
@GoPavel
Add missing ABC for Metric (#391)
27f04b6 
Fix #390
toumorokoshi pushed a commit to toumorokoshi/opentelemetry-python that referenced this issue Feb 17, 2020
@GoPavel @toumorokoshi
Add missing ABC for Metric (open-telemetry#391)
0f96e19 
Fix open-telemetry#390
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22 @danielkhan
Add initial benchmark suite (open-telemetry#390)
9855636 
* feat: add initial benchmark suite

* fix: remove nock

* feat: add propagator benchmarks

* fix: use new package names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing ABC for Metric GoPavel/opentelemetry-python
2 participants
@codeboten @GoPavel