Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/boto and ext/botocore: fails to export spans via jaeger #817

Closed
ThePumpingLemma opened this issue Jun 11, 2020 · 0 comments · Fixed by #866
Closed

ext/boto and ext/botocore: fails to export spans via jaeger #817

ThePumpingLemma opened this issue Jun 11, 2020 · 0 comments · Fixed by #866
Labels
bug Something isn't working good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks

Comments

@ThePumpingLemma
Copy link
Contributor

Describe your environment

opentelemetry-api = "=0.9b0"
opentelemetry-ext-boto = "=0.9b0"
opentelemetry-ext-botocore = "=0.9b0"
opentelemetry-ext-dbapi = "=0.9b0"
opentelemetry-ext-jaeger = "=0.9b0"
opentelemetry-ext-psycopg2= "=0.9b0"
opentelemetry-ext-requests = "=0.9b0"
opentelemetry-instrumentation = "=0.9b0"
opentelemetry-sdk = "=0.9b0"
python = "=3.7.4"

Steps to reproduce
Install and enable ext/boto with a jaeger exporter configured

What is the expected behavior?
Spans are exported via jaeger

What is the actual behavior?

Traceback (most recent call last):
  File "/opt/cadre/web/.venv/lib/python3.7/site-packages/opentelemetry/sdk/trace/export/__init__.py", line 80, in on_end
    self.span_exporter.export((span,))
  File "/opt/cadre/web/.venv/lib/python3.7/site-packages/opentelemetry/ext/jaeger/__init__.py", line 156, in export
    jaeger_spans = _translate_to_jaeger(spans)
  File "/opt/cadre/web/.venv/lib/python3.7/site-packages/opentelemetry/ext/jaeger/__init__.py", line 200, in _translate_to_jaeger
    tags.extend(_extract_tags(span.resource.labels))
AttributeError: 'str' object has no attribute 'labels'

Additional context
Span creation code stomps the resource field with a string, which is not the expected type of Resource:

Not sure what the intent is here, but maybe resource should be an attribute instead?

@ThePumpingLemma ThePumpingLemma added the bug Something isn't working label Jun 11, 2020
@codeboten codeboten added good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks labels Jun 11, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
Remove SpanOptions.isRecording as it seems to be quite useless and I found
only Span.isRecording in spec.

Also Java seems to have no such option for span creation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants