Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update opentelemetry-proto README with instructions #894

Closed
aabmass opened this issue Jul 9, 2020 · 3 comments · Fixed by #905
Closed

Update opentelemetry-proto README with instructions #894

aabmass opened this issue Jul 9, 2020 · 3 comments · Fixed by #905
Assignees
@aabmass
Labels
proto

Comments

@aabmass
Copy link
Member

aabmass commented Jul 9, 2020

Add instructions on how to regenerate/maintain the generated proto files to the README file
@aabmass
Copy link
Member Author

aabmass commented Jul 9, 2020

Can someone assign to me? :)

@codeboten
Copy link
Contributor

Done!

@ocelotl ocelotl added the proto label Jul 10, 2020
@ocelotl
Copy link
Contributor

ocelotl commented Jul 10, 2020

BTW, I was a bit confused about the VIRTUAL_ENV variable used in the proto-generating script. It could be something to explain in the README as well.

@aabmass aabmass mentioned this issue Jul 13, 2020
Merged
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
chore: update README top section (open-telemetry#894)
3e1b0af 
* new look

* new look
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aabmass aabmass

Labels
proto
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add instructions to proto package README aabmass/opentelemetry-python
3 participants
@codeboten @aabmass @ocelotl