Fix api/sdk setup.cfg to include missing python files #1091
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
include
line insetup.cfg
was causing only packages underopentelemetry.sdk
andopentelemetry
to be included, missing theopentelemetry.sdk
package itself (withversion.py
and__init__.py
files). I don't think we need theinclude
at all, so removed. It is not in any of the other packages' setup files.Fixes #1078
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Installing the packages (regular install, not editable) before and after into separate venvs and comparing the site-packages
Before:
After:
Diff of two venvs with
diff --color <(find venv-before/lib/python3.8/site-packages/ -type f -not -name "*.pyc" -printf "%P\n" | sort) <(find venv-after/lib/python3.8/site-packages/ -type f -not -name "*.pyc" -printf "%P\n" | sort)
So those 4 extra files were included after this change.
Checklist: