Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OTEL_PROPAGATORS #1123

Merged
merged 6 commits into from
Sep 23, 2020
Merged

Add support for OTEL_PROPAGATORS #1123

merged 6 commits into from
Sep 23, 2020

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Sep 16, 2020

Fixes #1058

Description

Add support for OTEL_PROPAGATORS

Fixes #1058

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • test_propagators

Checklist:

  • [X Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ocelotl ocelotl requested a review from a team September 16, 2020 20:57
@ocelotl ocelotl self-assigned this Sep 16, 2020
@codeboten codeboten added the release:required-for-ga To be resolved before GA release label Sep 17, 2020
codeboten
codeboten suggested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I would expect the b3 propagator to also be available through this mechanism and it would great to have a test confirming overriding the environment variable works as expected.

@codeboten
Copy link
Contributor

Also note open-telemetry/opentelemetry-specification#962 for reference on known propagators.

@ocelotl ocelotl requested a review from codeboten September 22, 2020 23:25
@ocelotl
Copy link
Contributor Author

ocelotl commented Sep 22, 2020

Thanks for the PR! I would expect the b3 propagator to also be available through this mechanism and it would great to have a test confirming overriding the environment variable works as expected.

Done, please re-review.

codeboten
codeboten approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments, LGTM

@codeboten codeboten merged commit 90d7400 into open-telemetry:master Sep 23, 2020
alertedsnake pushed a commit to alertedsnake/opentelemetry-python that referenced this pull request Sep 25, 2020
@ocelotl
Add support for OTEL_PROPAGATORS (open-telemetry#1123)
f170322 
Fixes open-telemetry#1058
@ocelotl ocelotl mentioned this pull request Oct 14, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@lzchen lzchen lzchen approved these changes

Assignees

@ocelotl ocelotl

Labels
release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for OTEL_PROPAGATORS
3 participants
@ocelotl @codeboten @lzchen