Add support for OTLP v0.5.0 #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
force-pushed
the
otlp-v0.5.0
branch
from
ffe32b9
to
13c9774
Compare
|
I am currently working on this, just for the record. |
|
Closed this PR by accident, reopening. |
ocelotl
force-pushed
the
otlp-v0.5.0
branch
from
349be99
to
aa6f055
Compare
Update metrics and trace
ocelotl
force-pushed
the
otlp-v0.5.0
branch
from
aa6f055
to
8fd1ca2
Compare
codeboten
changed the title
codeboten
commented
Sep 25, 2020
|
|
||
| if metric_descriptor.type == MetricDescriptor.Type.INT64: | ||
| elif isinstance(sdk_metric.instrument, (ValueRecorder)): | ||
| logger.warning("Skipping exporting of ValueRecorder metric") |
There was a problem hiding this comment.
Added an issue to track the work to support ValueRecorder: #1167
ocelotl
approved these changes
Sep 28, 2020
lzchen
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the version of OTLP supported to v0.5.0
Fixes #1071
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: