Added ability to extract span attributes from tornado request objects #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
tornado-request-attrs
branch
3 times, most recently
from
1bb0016 to
5a91eb2
Compare
owais
changed the title
owais
changed the title
NathanielRN
approved these changes
Sep 29, 2020
instrumentation/opentelemetry-instrumentation-tornado/README.rst
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-tornado/tests/test_instrumentation.py
Outdated
Show resolved
Hide resolved
| _excluded_urls = get_excluded_urls() | ||
| _traced_attrs = get_traced_request_attrs() |
There was a problem hiding this comment.
What about this to not have the function above?
Suggested change
| _traced_attrs = get_traced_request_attrs() | |
| _traced_attrs = [attr.strip() for attr in configuration.Configuration().TORNADO_TRACED_REQUEST_ATTRS.split(",")] if configuration.Configuration().TORNADO_TRACED_REQUEST_ATTRS else [] |
There was a problem hiding this comment.
Very similar functionality above uses a function so I think it's better to be consistent with existing code.
owais
force-pushed
the
tornado-request-attrs
branch
from
48f3240 to
4bdb84e
Compare
codeboten
added
the
instrumentation
lzchen
reviewed
Oct 2, 2020
instrumentation/opentelemetry-instrumentation-tornado/README.rst
Outdated
Show resolved
Hide resolved
lzchen
requested changes
Oct 2, 2020
owais
force-pushed
the
tornado-request-attrs
branch
from
72350c4 to
fbbba1f
Compare
OTEL_PYTHON_TONADO_TRACED_REQUEST_ATTRS env var can be set to a command separated list of attributes names that will be extracted from Tornado's request object and set as attributes on spans.
Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <enruizno@uwaterloo.ca>
owais
force-pushed
the
tornado-request-attrs
branch
2 times, most recently
from
aa607fc to
badd8d6
Compare
…st_instrumentation.py Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <enruizno@uwaterloo.ca>
owais
force-pushed
the
tornado-request-attrs
branch
from
badd8d6 to
5c0bc91
Compare
lzchen
approved these changes
Oct 5, 2020
codeboten
approved these changes
Oct 7, 2020
Comment on lines
+75
to
+81
| def get_traced_request_attrs(): | ||
| attrs = configuration.Configuration().TORNADO_TRACED_REQUEST_ATTRS or "" | ||
| if attrs: | ||
| attrs = [attr.strip() for attr in attrs.split(",")] | ||
| else: | ||
| attrs = [] | ||
| return attrs |
There was a problem hiding this comment.
is it worth moving this code into the utils package as well since it seems likely to be repeated?
There was a problem hiding this comment.
Agree. I think it might be better to have convenience methods on the configuration class itself for common config items. Something like,
cfg = configuration.Configuration()
cfg.traced_methods("django")
cfg.excluded_urls("django")There was a problem hiding this comment.
Created an issue for it. #1217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OTEL_PYTHON_TORNADO_TRACED_REQUEST_ATTRS env var can be set to a command
separated list of attributes names that will be extracted from Tornado's
request object and set as attributes on spans.
Also fixes #1176
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: