Renaming batcher to processor #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
lzchen
reviewed
Oct 6, 2020
| self.assertEqual(len(processor._batch_map), 1) | ||
| self.assertIsNotNone(processor._batch_map.get(batch_key)) | ||
| self.assertEqual(processor._batch_map.get(batch_key).current, 0) | ||
| self.assertEqual(processor._batch_map.get(batch_key).checkpoint, 1.0) | ||
|
|
||
| def test_batcher_process_not_exists(self): |
There was a problem hiding this comment.
Nit: Remove "batcher" from test names?
There was a problem hiding this comment.
removed, thanks for the catch
lzchen
approved these changes
Oct 6, 2020
|
|
ocelotl
suggested changes
Oct 6, 2020
There was a problem hiding this comment.
Just a few instances of batcher remain, @codeboten, if you think they are ok, I'll approve as it is. 👍
| @@ -116,7 +116,7 @@ def test_collect_disabled_metric(self): | |||
| def test_collect_observers(self): | |||
| meter = metrics.MeterProvider().get_meter(__name__) | |||
| batcher_mock = mock.Mock() | |||
| meter.batcher = batcher_mock | |||
| meter.processor = batcher_mock | |||
There was a problem hiding this comment.
Rename batcher_mock to processor_mock?
Fixed them just as you were reviewing. |
Perfect, approving 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renaming the Batcher to Processor as per metrics spec.
Fixes #1202
Type of change
Please delete options that are not relevant.
Checklist: