Adding metric collection as part of instrumentations - Django #1230
Conversation
.../opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Show resolved
Hide resolved
.../opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Show resolved
Hide resolved
.../opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Outdated
Show resolved
Hide resolved
.../opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Outdated
Show resolved
Hide resolved
| def _get_metric_labels_from_attributes(attributes): | ||
| labels = {} | ||
| labels["http.method"] = attributes.get("http.method", "") | ||
| for attrs in _ATTRIBUTES_BY_PREFERENCE: |
There was a problem hiding this comment.
Maybe just declare the _ATTRIBUTES_BY_PREFERENCE here since it is only used once?
There was a problem hiding this comment.
Defined once on module level so it doesn't have to be defined everytime a request is called.
.../opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Outdated
Show resolved
Hide resolved
.../opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Outdated
Show resolved
Hide resolved
| if all(labels_from_attributes.values()): | ||
| labels.update(labels_from_attributes) | ||
| break | ||
| if attributes.get("http.flavor"): |
There was a problem hiding this comment.
This may have the same problem.
| if attributes.get("http.flavor"): | |
| if attributes.get("http.flavor") is not None: |
There was a problem hiding this comment.
I don't believe we want to set the label if value is an empty string.
There was a problem hiding this comment.
Nevertheless, we may end up setting the label when the value is an empty string here?
There was a problem hiding this comment.
I think http.method should always be populated. That was just for sanity.
.../opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Outdated
Show resolved
Hide resolved
| if all(labels_from_attributes.values()): | ||
| labels.update(labels_from_attributes) | ||
| break | ||
| if attributes.get("http.flavor"): |
There was a problem hiding this comment.
Nevertheless, we may end up setting the label when the value is an empty string here?
…#1230) Co-authored-by: Mayur Kale <mayurkale@google.com>
Similar to #1116.
Adding the ability to collect duration metrics from
Djangoinstrumentation.Semantic conventions for metrics can be found here
Currently
djangoonly supports SERVER type (since we don't have database tracking yet). TheHTTPMetricRecorderis also being passed viasettingsfrom theDjangoInstrumentorto themiddleware.Also included in this PR:
MetricMixinin the instrumentation package: Support bothSERVERandCLIENTtypes, add a function to calculate duration without the use of context manager