-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ParentBased sampler for implicit parent spans #1394
Merged
codeboten
merged 6 commits into
open-telemetry:master
from
mariojonke:fix-parent-based-sampler
Nov 25, 2020
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fa2146d
Fix ParentBased sampler for implicit parent spans
mariojonke d5f1a69
Fix trace_state erasure for dropped spans
mariojonke 0513096
Merge branch 'master' into fix-parent-based-sampler
lzchen 56049e1
Merge branch 'master' into fix-parent-based-sampler
551adfa
Merge branch 'master' into fix-parent-based-sampler
lzchen 7cfd1e3
Merge branch 'master' into fix-parent-based-sampler
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to pass in the
trace_state
for dropped spans?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes as otherwise the trace breaks when the span is propagated further. E.g.
flask
instrumentation extracts span a span where the sampling flag in the trace parent isfalse
. The handler in theflask
app makes an outgoing HTTP request with therequests
library. Therequests
instrumentation has theflask
span as parent so the created span will be dropped. The dropped span however is used for injecting/propagation, so it needs to include thetrace_state
of the parent.w3c_tracecontext
tests also rely on that the trace_state gets propagated.