Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Resources follow semantic conventions #1480

Merged
merged 6 commits into from
Jan 25, 2021

Conversation

hectorhdzg
Copy link
Member

Adding global variables with supported resources
Adding default service name population

Fixes #1477

Adding default service name population
@hectorhdzg hectorhdzg requested review from a team, codeboten and aabmass and removed request for a team December 15, 2020 00:51
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 15, 2020

CLA Signed

The committers are authorized under a signed CLA.

@hectorhdzg hectorhdzg changed the title Adding global variables with supported resources Make sure Resources follow semantic conventions Dec 15, 2020
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking on removing a duplicated variable, otherwise it looks good. Were the semantic conventions generated? If not, is this something that would be doable using the generator: https://github.com/open-telemetry/build-tools/tree/master/semantic-conventions?

CONTAINER_IMAGE_NAME = "container.image.name"
CONTAINER_IMAGE_TAG = "container.image.tag"
CONTAINER_NAME = "container.name"
CONTAINER_NAME = "container.name"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dup

@@ -38,7 +38,11 @@ def test_resource(self):
def test_resource_empty(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if this test should be renamed since it's not using the empty resource (there's a separate create_empty method for empty resources)

@lzchen
Copy link
Contributor

lzchen commented Jan 21, 2021

@hectorhdzg
Any updates on this PR?

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure Resources follow semantic conventions
3 participants