Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distro: fix auto instrumentation with otlp OTEL_TRACES_EXPORTER env var #1657

Merged
merged 8 commits into from
Mar 6, 2021

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Mar 2, 2021

Description

Initializing otel distro failed due to wrong usage of set.pop(). Fixed it and added test cases.

Fixes #1623

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added unit tests and tested with the same setup as in the original issue.

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of opentelemetry-instrumentation/ have changed

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@seemk seemk requested review from a team, aabmass and ocelotl and removed request for a team March 2, 2021 12:36
@seemk seemk changed the title Fix auto instrumentation with otlp OTEL_TRACES_EXPORTER env var distro: fix auto instrumentation with otlp OTEL_TRACES_EXPORTER env var Mar 2, 2021
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@codeboten codeboten merged commit 94e3a4a into open-telemetry:main Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: pop() takes no arguments (1 given) with otlp exporter 0.18b0
4 participants