split jaeger exporter for proto/thrift #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
added 2 commits
March 15, 2021 15:48
codeboten
requested review from
a team,
aabmass and
hectorhdzg
and removed request for
a team
owais
reviewed
Mar 16, 2021
exporter/opentelemetry-exporter-jaeger-thrift/examples/jaeger_exporter_example.py
Outdated
Show resolved
Hide resolved
...elemetry-exporter-jaeger-thrift/src/opentelemetry/exporter/jaeger/thrift/translate/thrift.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-jaeger-thrift/proto/api_v2/collector.proto
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-jaeger-thrift/proto/api_v2/model.proto
Outdated
Show resolved
Hide resolved
added 2 commits
March 16, 2021 08:38
srikanthccv
reviewed
Mar 16, 2021
...rter/opentelemetry-exporter-jaeger-proto/src/opentelemetry/exporter/jaeger/proto/__init__.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
…/exporter/jaeger/proto/__init__.py Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
owais
approved these changes
Mar 16, 2021
lzchen
reviewed
Mar 16, 2021
| Protobuf via gRPC. | ||
| insecure: True if collector has no encryption or authentication | ||
| credentials: Credentials for server authentication. | ||
| max_tag_value_length: Max length string attribute values can have. Set to None to disable. |
There was a problem hiding this comment.
Does udp_split_oversized_batches apply to proto?
There was a problem hiding this comment.
it does not, proto uses http
lzchen
approved these changes
Mar 16, 2021
srikanthccv
approved these changes
Mar 17, 2021
| request = PostSpansRequest(batch=batch) | ||
| self._collector_grpc_client.PostSpans(request) | ||
|
|
||
| return SpanExportResult.SUCCESS |
There was a problem hiding this comment.
Out of scope for this PR. Probably we should follow up in another issue/PR. This seems to send SpanExportResult.SUCCESS status always; we should handle failures and return the correct export status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This splits the Jaeger exporter into 3 packages to reduce the amount of dependency a user has to take on to export using their preferred serialization method:
opentelemetry-exporter-jaegeropentelemetry-exporter-jaeger-protoopentelemetry-exporter-jaeger-thriftThe first package adds a dependency on the other two for users that don't mind installing both exporters.
Part of #1604
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Documentation in the contrib repo needs updating, but it is not a hard dependency
Checklist: