Upgrade Mypy to version 0.812 #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmolenda-sumo
requested review from
a team,
ocelotl and
lzchen
and removed request for
a team
|
|
|
Good catch! Thanks for fixing. Will review once again once CI passes. |
dmolenda-sumo
force-pushed
the
upgrade_mypy_to_0.812
branch
from
0432023 to
cdffe17
Compare
owais
approved these changes
Mar 18, 2021
lzchen
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1575
Mypy Was updated to 0.812 version.
It turned out that in the existing configuration not all files from opentelemetry-api/src/opentelemetry/ and opentelemetry-api/tests/ were processed by Mypy. It was caused by Mypy 0.790 being unable to detect some of the packages.
2 typing issues were found in opentelemetry-api/src/opentelemetry/, 72 in opentelemetry-api/tests/.
I've fixed all issues in the main code. For tests, I marked all previously unchecked files as ignore. It would be good to fix them in separate PR.
How Has This Been Tested?