Update bootstrap cmd to use exact version when installing instrumentation packages #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
bootstrap-install-same-version-as-instrumentation
branch
3 times, most recently
from
45a01bb to
7656569
Compare
instrumentation packages This commit updates the bootstrap command to ensure it'll install instrumentation packages compatible with the opentelemetry-instrument package. Since opentelemetry-instrumentation (as as a result all instrumentations) are not stable yet, installing an instrumentation package older or newer than opentelemtry-instrumentation can result in a broken setup. This commit updates the bootstrap command so that it'll always install instrumentation packages with the exact same version as it's own.
owais
force-pushed
the
bootstrap-install-same-version-as-instrumentation
branch
from
7656569 to
2e27f12
Compare
owais
requested review from
a team,
codeboten and
ocelotl
and removed request for
a team
I think this will be easier as well once we move the |
lzchen
approved these changes
Mar 30, 2021
lzchen
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit updates the bootstrap command to ensure it'll install
instrumentation packages compatible with the opentelemetry-instrument
package.
Since opentelemetry-instrumentation (as as a result all
instrumentations) are not stable yet, installing an instrumentation
package older or newer than opentelemtry-instrumentation can result in
a broken setup. This commit updates the bootstrap command so that it'll
always install instrumentation packages with the exact same version as
it's own.
This will only work as long as we keep releasing newer versions of all instrumentation packages in tandem with the opentelemetry-instrumentation package but I think we'll keep doing that until opentelemetry-instrumentation hits 1.0.
Type of change
Please delete options that are not relevant.
Checklist: