Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy tracer/provider to enable lazy setup of tracing pipeline #1726

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented Mar 29, 2021

Description

Introduces a proxy tracer provider and proxy tracer implementations. The proxies return noop implementations until a global tracer provider is set by the user. Once a global provider is set the proxies delegate to the real provider and tracer implementations.

Updated get_tracer_provider() to return a proxy tracer provider if a the user has not set a global provider via code or env vars.

Fixes #1159
Fixes #1276
Fixes open-telemetry/opentelemetry-python-contrib#405

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Does This PR Require a Contrib Repo Change?

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais changed the title Prototype proxy tracer/provider to enable lazy setup of tracing pipeline POC proxy tracer/provider to enable lazy setup of tracing pipeline Mar 29, 2021
@owais owais force-pushed the proxy-tracer branch 12 times, most recently from 763730c to 622d550 Compare April 3, 2021 23:01
@owais owais marked this pull request as ready for review April 3, 2021 23:31
@owais owais requested review from a team, aabmass and hectorhdzg and removed request for a team April 3, 2021 23:31
@owais owais changed the title POC proxy tracer/provider to enable lazy setup of tracing pipeline Proxy tracer/provider to enable lazy setup of tracing pipeline Apr 3, 2021
@owais
Copy link
Contributor Author

owais commented Apr 3, 2021

Docker hub is having issues right now and as a result docker test can't pull some images. Either that or the images were deleted. Will take a look tomorrow if it doesn't fix on it's own.

@owais owais requested a review from srikanthccv April 7, 2021 03:25
@lzchen lzchen merged commit 8774276 into open-telemetry:main Apr 7, 2021
@owais owais deleted the proxy-tracer branch April 7, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants