Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not skip sequence attribute on decode error #2097

Merged
merged 4 commits into from
Sep 10, 2021
Merged

Do not skip sequence attribute on decode error #2097

merged 4 commits into from
Sep 10, 2021

Conversation

srikanthccv
Copy link
Member

Description

Fixes #2094

@srikanthccv srikanthccv marked this pull request as ready for review September 5, 2021 06:11
@srikanthccv srikanthccv requested a review from a team September 5, 2021 06:11
@owais owais enabled auto-merge (squash) September 9, 2021 17:19
@srikanthccv
Copy link
Member Author

Flaky tests. Does it still auto merge after manual workflow run?

@owais
Copy link
Contributor

owais commented Sep 9, 2021

It should, yes.

@owais owais merged commit df1f842 into open-telemetry:main Sep 10, 2021
@srikanthccv srikanthccv deleted the issue-2094 branch September 10, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

@owais owais owais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_clean_attribute shouldn't skip attributes
3 participants
@srikanthccv @owais @ocelotl