Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OTEL_ATTRIBUTE_COUNT_LIMIT #2139

Merged
merged 4 commits into from
Sep 25, 2021
Merged

Add support for OTEL_ATTRIBUTE_COUNT_LIMIT #2139

merged 4 commits into from
Sep 25, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented Sep 23, 2021 •
edited
Loading

Description

Fixes #2055
Fixes #2111

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Updated and added tests

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais force-pushed the support-otel-attribute-count-limit branch 3 times, most recently from 57edcc5 to 0a1a444 Compare September 23, 2021 12:54
@owais owais force-pushed the support-otel-attribute-count-limit branch from 0a1a444 to 2991c12 Compare September 23, 2021 12:55
@owais owais marked this pull request as ready for review September 23, 2021 12:58
@owais owais requested a review from a team September 23, 2021 12:58
@owais @srikanthccv
Update opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
fb31e74 
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
@srikanthccv srikanthccv added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Sep 24, 2021
@owais owais enabled auto-merge (squash) September 25, 2021 00:38
@owais owais force-pushed the support-otel-attribute-count-limit branch from cb288c0 to 0b42002 Compare September 25, 2021 00:42
@owais owais disabled auto-merge September 25, 2021 23:21
@owais owais enabled auto-merge (squash) September 25, 2021 23:21
@owais owais merged commit e6d4b9c into open-telemetry:main Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update limits implementation to comply with the spec Support OTEL_ATTRIBUTE_COUNT_LIMIT
3 participants
@owais @lzchen @srikanthccv