Fix OTLP HTTP Endpoint Usage #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
changed the title
srikanthccv
approved these changes
Mar 1, 2022
|
@TylerHelmuth Please add CHANGELOG entry |
CHANGELOG updated. |
srikanthccv
reviewed
Mar 1, 2022
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
lzchen
reviewed
Mar 1, 2022
...porter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/trace_exporter/__init__.py
Show resolved
Hide resolved
lzchen
approved these changes
Mar 1, 2022
|
Technically this is a breaking change. However since it is fixing something that doesn't conform to the spec, I think it falls under "bug fix" which is the message we have told users. |
lzchen
added
the
Approve Public API check
lzchen
reviewed
Mar 1, 2022
Co-authored-by: Leighton Chen <lechen@microsoft.com>
srikanthccv
approved these changes
Mar 1, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change updates the OTLP HTTP trace exporter to append
v1/tracesto theOTEL_EXPORTER_OTLP_ENDPOINTenv var value if it is used.Fixes #2443
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I tested this change by writing 2 new unit tests, and updating others.
Does This PR Require a Contrib Repo Change?
Checklist: