Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure trace flags are parsed properly when extracting traceparent and expand tests #2577

Merged
merged 3 commits into from
Apr 1, 2022

Conversation

deejgregor
Copy link
Contributor

@deejgregor deejgregor commented Mar 30, 2022

Description

This PR does two things:

  1. Make sure trace flags are parsed properly when extracting traceparent
  2. Expands tests for traceparent parsing (including the above issue) and trace flags handling.

Fixes # (issue) (no current issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • The test which exercises the traceparent trace flags parsing issue is test_extract_non_decimal_trace_flags in opentelemetry-api/tests/propagators/test_propagators.py and passes with the change to opentelemetry-api/src/opentelemetry/trace/propagation/tracecontext.py.
  • Added a number of other unit tests to exercise related functionality.

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • [ ] Documentation has been updated

@deejgregor deejgregor requested a review from a team March 30, 2022 22:49
@deejgregor deejgregor force-pushed the tracecontext-parsing branch from 30b6511 to 4c6a0a7 Compare March 30, 2022 22:51
@deejgregor deejgregor force-pushed the tracecontext-parsing branch from 4c6a0a7 to 50502bd Compare March 30, 2022 23:04
@srikanthccv srikanthccv merged commit e280a8a into open-telemetry:main Apr 1, 2022
@deejgregor deejgregor deleted the tracecontext-parsing branch February 17, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants