Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MetricReader temporality controls #2637

Merged
merged 12 commits into from
Apr 27, 2022
Merged

Implement MetricReader temporality controls #2637

merged 12 commits into from
Apr 27, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Apr 22, 2022 •
edited
Loading

Fixes #2627
Fixes #2636

@ocelotl ocelotl requested a review from a team April 22, 2022 02:45
@ocelotl ocelotl self-assigned this Apr 22, 2022
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 22, 2022
@ocelotl ocelotl force-pushed the issue_2627 branch 2 times, most recently from 93dafb0 to 0d06123 Compare April 23, 2022 22:07
@ocelotl ocelotl requested a review from srikanthccv April 25, 2022 16:38
codeboten
codeboten reviewed Apr 25, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, just a few questions

opentelemetry-sdk/src/opentelemetry/sdk/_metrics/instrument.py Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader.py Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables.py Show resolved Hide resolved
opentelemetry-sdk/tests/metrics/test_periodic_exporting_metric_reader.py Show resolved Hide resolved
@ocelotl ocelotl requested a review from codeboten April 25, 2022 22:18
@ocelotl ocelotl removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 25, 2022
codeboten
codeboten reviewed Apr 26, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ocelotl ocelotl requested a review from codeboten April 26, 2022 21:41
@ocelotl ocelotl merged commit b0777a3 into open-telemetry:main Apr 27, 2022
@ocelotl ocelotl deleted the issue_2627 branch April 27, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ocelotl @codeboten @srikanthccv