Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeouts to metric SDK #2653

Merged
merged 8 commits into from
May 6, 2022
Merged

Add timeouts to metric SDK #2653

merged 8 commits into from
May 6, 2022

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Apr 29, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #2402

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tests pass

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@aabmass aabmass force-pushed the timeout branch 2 times, most recently from 11c51db to c66b40b Compare April 29, 2022 21:49
This was referenced May 2, 2022
Closed
Merged
ocelotl
ocelotl reviewed May 4, 2022
View reviewed changes
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, the idea for this PR is just to add a timeout parameter that is to be implemented by underlying components, right?

opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/export/__init__.py Outdated Show resolved Hide resolved
@aabmass aabmass marked this pull request as ready for review May 5, 2022 22:41
@aabmass aabmass requested a review from a team May 5, 2022 22:41
@aabmass aabmass requested review from srikanthccv and ocelotl May 6, 2022 03:37
srikanthccv
srikanthccv approved these changes May 6, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
aabmass and others added 2 commits May 6, 2022 11:22
@aabmass @srikanthccv
Update CHANGELOG.md
f5339d0 
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
@aabmass
use self.fail in tests
49084fc
@aabmass aabmass mentioned this pull request May 6, 2022
Closed
@ocelotl ocelotl merged commit a72c7de into open-telemetry:main May 6, 2022
@aabmass aabmass deleted the timeout branch May 6, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@lzchen lzchen lzchen approved these changes

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement timeout mechanism for several metrics components
4 participants
@aabmass @ocelotl @lzchen @srikanthccv