Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proto to v0.19.0 #3040

Closed
wants to merge 5 commits into from
Closed

Update proto to v0.19.0 #3040

wants to merge 5 commits into from

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Nov 16, 2022 •
edited
Loading

No description provided.

@ocelotl ocelotl self-assigned this Nov 16, 2022
@ocelotl ocelotl mentioned this pull request Nov 16, 2022
Closed
@ocelotl ocelotl requested review from psigen and removed request for psigen November 28, 2022 22:16
@ocelotl ocelotl marked this pull request as ready for review November 28, 2022 22:17
@ocelotl ocelotl requested a review from a team November 28, 2022 22:17
psigen
psigen approved these changes Dec 2, 2022
View reviewed changes
Copy link

@psigen psigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should solve the immediate problem, afaik :)

@aabmass
Copy link
Member

aabmass commented Dec 2, 2022 •
edited
Loading

@ocelotl I split the protoc version bump changes into a separate PR without the OTLP upgrade in it. I also updated tox to test against each version of protobuf. #3070

Let's leave this one open to upgrade OTLP version to v0.19.0 but try to get #3070 in the next release.

@ocelotl ocelotl added Skip Changelog PRs that do not require a CHANGELOG.md entry Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary labels Dec 15, 2022
@lzchen
Copy link
Contributor

lzchen commented Jan 9, 2023

@ocelotl @aabmass
What's the status of this pr? Is it still valid after #3070?

@aabmass
Copy link
Member

aabmass commented Jan 30, 2023

Yes this is a separate issue

@ocelotl
Copy link
Contributor Author

ocelotl commented Feb 2, 2024

Superseded by #3355

@ocelotl ocelotl closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psigen psigen psigen approved these changes

Assignees

@ocelotl ocelotl

Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ocelotl @aabmass @lzchen @psigen @srikanthccv