Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear unwanted global variables in module init #3095

Closed
wants to merge 4 commits into from
Closed

fix: clear unwanted global variables in module init #3095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b6e58b
fix: clear key value in module level
gen-xu Dec 19, 2022
f193545
misc: ignore mypy false postivie
gen-xu Jan 3, 2023
68980a8
Merge branch 'main' into gen/del_key_value_on_init
srikanthccv Jan 8, 2023
4d60672
Merge branch 'main' into gen/del_key_value_on_init
srikanthccv Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix validation of baggage values
([#3058](https://github.com/open-telemetry/opentelemetry-python/pull/3058))

- Clean `key`, `value` at module `__init__` after dynamically adding to `__all__`
([#3095](https://github.com/open-telemetry/opentelemetry-python/pull/3095))

## Version 1.15.0/0.36b0 (2022-12-09)

- Regenerate opentelemetry-proto to be compatible with protobuf 3 and 4
Expand Down
1 change: 1 addition & 0 deletions opentelemetry-api/src/opentelemetry/_logs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,4 @@
if not key.startswith("_"):
value.__module__ = __name__ # type: ignore
__all__.append(key)
del key, value # type: ignore
1 change: 1 addition & 0 deletions opentelemetry-sdk/src/opentelemetry/sdk/_logs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@
if not key.startswith("_"):
value.__module__ = __name__
__all__.append(key)
del key, value # type: ignore
1 change: 1 addition & 0 deletions opentelemetry-sdk/src/opentelemetry/sdk/_logs/export/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@
if not key.startswith("_"):
value.__module__ = __name__
__all__.append(key)
del key, value # type: ignore
1 change: 1 addition & 0 deletions opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,4 @@
if not key.startswith("_"):
value.__module__ = __name__
__all__.append(key)
del key, value # type: ignore
1 change: 1 addition & 0 deletions opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@
if not key.startswith("_"):
value.__module__ = __name__
__all__.append(key)
del key, value # type: ignore
1 change: 1 addition & 0 deletions opentelemetry-sdk/src/opentelemetry/sdk/metrics/view/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@
if not key.startswith("_"):
value.__module__ = __name__
__all__.append(key)
del key, value # type: ignore