-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add db metric name to semantic conventions #3115
Add db metric name to semantic conventions #3115
Conversation
Thanks for the PR, but these are auto-generated files and are not to be modified by hand (although nothing prevents you from doing it). Here is the script that takes the spec version and produces the semconv files https://github.com/open-telemetry/opentelemetry-python/blob/main/scripts/semconv/generate.sh |
Ah, sorry, I see this is a DB semconv which was manually added. There was some issue which prevented us from making this automated. I think we can merge this. It would be better if we could auto-generate as we do for the tracing. |
Ohh I didn't know it should be auto-generated I saw that the http metric names are manually added. |
This one #2977 |
Thanks! |
I would suggest adding an entry since external users can consume this change. |
Ohh I see, Thank you for the comment |
* main: fixed all instances of @tracer.start_as_current_span("name"): to @tracer.start_as_current_span("name") as decorators do not have colons (open-telemetry#3127) Add attribute name to type warning message. (open-telemetry#3124) Fix requirements file for example (open-telemetry#3126) Add db metric name to semantic conventions (open-telemetry#3115) Adds environment variables for log exporter (open-telemetry#3037) Fix bug in example (open-telemetry#3111)
Description
I started to implement dbapi metrics instrumentation and
I figure out that db.client.connections.usage metric name is missing in the semantic conventions
According to the specs: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/database-metrics.md
Type of change
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: