Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some test environments to 3.10 #3149

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Update some test environments to 3.10 #3149

merged 3 commits into from
Feb 14, 2023

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jan 27, 2023

Fixes #3148

@ocelotl ocelotl self-assigned this Jan 27, 2023
@ocelotl ocelotl requested a review from a team January 27, 2023 19:37
@ocelotl
Copy link
Contributor Author

ocelotl commented Jan 27, 2023

@tombruijn

1 similar comment
@ocelotl
Copy link
Contributor Author

ocelotl commented Jan 27, 2023

@tombruijn

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 27, 2023
tombruijn
tombruijn approved these changes Jan 30, 2023
View reviewed changes
Copy link

@tombruijn tombruijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgraded tasks all run without issue on my M1 MacBook 👌

@tombruijn
Copy link

tombruijn commented Jan 30, 2023 •
edited
Loading

@ocelotl The GitHub workflow file also needs to be updated to the new Python version, like in this PR: open-telemetry/opentelemetry-python-contrib#1609

I see the same message in the lint, tracecontext and spellcheck steps in this PR.

spellcheck create: /home/runner/work/opentelemetry-python/opentelemetry-python/.tox/spellcheck
SKIPPED: InterpreterNotFound: python3.10
___________________________________ summary ____________________________________
SKIPPED:  spellcheck: InterpreterNotFound: python3.10
  congratulations :)

@ocelotl
Copy link
Contributor Author

ocelotl commented Feb 13, 2023

@ocelotl The GitHub workflow file also needs to be updated to the new Python version, like in this PR: open-telemetry/opentelemetry-python-contrib#1609

I see the same message in the lint, tracecontext and spellcheck steps in this PR.

spellcheck create: /home/runner/work/opentelemetry-python/opentelemetry-python/.tox/spellcheck
SKIPPED: InterpreterNotFound: python3.10
___________________________________ summary ____________________________________
SKIPPED:  spellcheck: InterpreterNotFound: python3.10
  congratulations :)

Nice catch, fixed ✌️

@ocelotl ocelotl enabled auto-merge (squash) February 13, 2023 22:49
@ocelotl ocelotl merged commit 0f76769 into open-telemetry:main Feb 14, 2023
@ocelotl ocelotl deleted the issue_3148 branch February 14, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@lzchen lzchen lzchen approved these changes

@tombruijn tombruijn tombruijn approved these changes

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update lint and other environments to 3.10
4 participants
@ocelotl @tombruijn @lzchen @srikanthccv