Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make entry_points behave the same across Python versions #3168

Closed
wants to merge 11 commits into from
Closed

Make entry_points behave the same across Python versions #3168

wants to merge 11 commits into from

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Feb 8, 2023

Fixes #3167

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 8, 2023
@ocelotl ocelotl self-assigned this Feb 8, 2023
@ocelotl ocelotl requested a review from a team February 8, 2023 01:21
@ocelotl ocelotl requested a review from shalevr February 9, 2023 04:07
@ocelotl ocelotl mentioned this pull request Feb 23, 2023
Closed
@lzchen
Copy link
Contributor

lzchen commented Feb 23, 2023

I'm still not sure about the purpose of this change. Could you be more specific about the issue description or provide an example?

@ocelotl
Copy link
Contributor Author

ocelotl commented Feb 24, 2023

I'm still not sure about the purpose of this change. Could you be more specific about the issue description or provide an example?

@lzchen PTAL here.

@ocelotl ocelotl mentioned this pull request Feb 24, 2023
Merged
@ocelotl ocelotl requested a review from lzchen February 24, 2023 23:53
@ocelotl ocelotl requested a review from lzchen February 28, 2023 17:20
@ocelotl ocelotl force-pushed the issue_3167 branch 2 times, most recently from 001a70d to f3839c9 Compare March 13, 2023 23:22
@ocelotl ocelotl requested a review from aabmass March 13, 2023 23:24
@ocelotl ocelotl mentioned this pull request Mar 14, 2023
Closed
7 tasks
@ocelotl
Copy link
Contributor Author

ocelotl commented Mar 14, 2023

May be overridden by #3217.

@lzchen lzchen mentioned this pull request Mar 15, 2023
Merged
@ocelotl
Copy link
Contributor Author

ocelotl commented Mar 16, 2023

Closing in favor of #3217

@ocelotl ocelotl closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@shalevr shalevr Awaiting requested review from shalevr

@aabmass aabmass Awaiting requested review from aabmass

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make entry_points behave the same across Python versions
5 participants
@ocelotl @lzchen @aabmass @shalevr @srikanthccv