-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix headers types mismatch for OTLP Exporters #3226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…header concatenation issue
|
sreejitkar
changed the title
Removed Tight Coupling from OTLP Exporters for GRPC
Removed Tight Coupling from OTLP Exporters for GRPC for #3209
Mar 20, 2023
sreejitkar
changed the title
Removed Tight Coupling from OTLP Exporters for GRPC for #3209
Removed Tight Coupling from OTLP Exporters for GRPC
Mar 20, 2023
srikanthccv
changed the title
Removed Tight Coupling from OTLP Exporters for GRPC
Fix headers types mismatch for OTLP Exporters
Mar 20, 2023
Hi @srikanthccv , Could you please help me with the next steps for merge ? |
Thanks for the PR; It will be merged when it gets enough approvals without any pending comments. |
srikanthccv
approved these changes
Mar 22, 2023
Looks like some checks are failing because of a bad SHA from the parent branch |
lzchen
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The said issue restricts the users from sending
headers
astuples
as the type signature is tightly coupled with the older version ofOTLPExporterMixin
.Fixes #3209
Type of change
OTLPExporterMixin
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: