Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headers types mismatch for OTLP Exporters #3226

Merged
merged 5 commits into from
Mar 29, 2023

Conversation

sreejitkar
Copy link
Contributor

@sreejitkar sreejitkar commented Mar 20, 2023

Description

The said issue restricts the users from sending headers as tuples as the type signature is tightly coupled with the older version of OTLPExporterMixin.

Fixes #3209

Type of change

  • Corrected the Type signatures of all OTLPExporters
  • Removed header concatenation issue in the OTLPExporterMixin

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran Unitest for all Exporters and Mixins

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 20, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sreejitkar / name: Sreejit Kar (64c04f0)

@sreejitkar sreejitkar marked this pull request as ready for review March 20, 2023 18:22
@sreejitkar sreejitkar requested a review from a team March 20, 2023 18:22
@sreejitkar sreejitkar changed the title Removed Tight Coupling from OTLP Exporters for GRPC Removed Tight Coupling from OTLP Exporters for GRPC for #3209 Mar 20, 2023
@sreejitkar sreejitkar changed the title Removed Tight Coupling from OTLP Exporters for GRPC for #3209 Removed Tight Coupling from OTLP Exporters for GRPC Mar 20, 2023
@srikanthccv srikanthccv changed the title Removed Tight Coupling from OTLP Exporters for GRPC Fix headers types mismatch for OTLP Exporters Mar 20, 2023
@sreejitkar
Copy link
Contributor Author

Hi @srikanthccv , Could you please help me with the next steps for merge ?

@srikanthccv
Copy link
Member

Thanks for the PR; It will be merged when it gets enough approvals without any pending comments.

@sreejitkar
Copy link
Contributor Author

Looks like some checks are failing because of a bad SHA from the parent branch

@srikanthccv srikanthccv enabled auto-merge (squash) March 29, 2023 15:50
auto-merge was automatically disabled March 29, 2023 18:00

Pull request was closed

@srikanthccv srikanthccv reopened this Mar 29, 2023
@srikanthccv srikanthccv enabled auto-merge (squash) March 29, 2023 18:10
@srikanthccv srikanthccv merged commit c11d551 into open-telemetry:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLPSpanExporter headers argument is tightly coupled to specific types
3 participants