Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug where BLRP export tracked as tracing #3375

Merged

Conversation

jeremydvoss
Copy link
Contributor

@jeremydvoss jeremydvoss commented Jul 11, 2023

Description

I noticed some export calls being tracked when using request and urllib3 instrumentations along with logging. It turns out the BLRP was failing to suppress the export call because of a typo.

Fixes #3376

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested manually to confirm bug exists before change and is removed after change.

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@jeremydvoss jeremydvoss requested a review from a team July 11, 2023 00:25
CHANGELOG.md Outdated Show resolved Hide resolved
@jeremydvoss jeremydvoss force-pushed the log-export-suppress-bug-fix branch from edd0981 to 4896b72 Compare July 11, 2023 14:50
@ocelotl ocelotl merged commit 72c1f5b into open-telemetry:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLRP Export unsupressed.
4 participants