Add runtime validation in setAttribute

opentelemetry-api/src/opentelemetry/util/types.py

@@ -15,5 +15,5 @@
 
 import typing
 
-AttributeValue = typing.Union[str, bool, float]
+AttributeValue = typing.Union[str, bool, int, float, list]
 Attributes = typing.Optional[typing.Dict[str, AttributeValue]]

opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

@@ -208,6 +208,27 @@ def set_attribute(self, key: str, value: types.AttributeValue) -> None:
         if has_ended:
             logger.warning("Setting attribute on ended span.")
             return
+
+        if not isinstance(value, (int, float, bool, str, list)):
+            logger.warning("Invalid data type for attribute value")
+            return
+        # If value is of type list, validate all items are of same,
+        # valid data type
+        if isinstance(value, list) and len(value) > 0:
+            first_element_data_type = type(value[0])
+            # If first value is numeric, validate all values are numeric
+            if first_element_data_type in (int, float):
+                if any(not isinstance(item, (int, float)) for item in value):
+                    logger.warning("All data types of attribute value arrays must be identical")
+                    return
+            # Else, validate all values are of same type
+            elif first_element_data_type in (bool, str):
+                if any(not isinstance(item, first_element_data_type) for item in value):
+                    logger.warning("All data types of attribute value arrays must be identical")
+                    return
+            else:
+                logger.warning("Invalid data type in value array")
+                return
         self.attributes[key] = value
 
     def add_event(

opentelemetry-sdk/tests/trace/test_trace.py

@@ -368,7 +368,11 @@ def test_attributes(self):
             root.set_attribute("attr-key", "attr-value1")
             root.set_attribute("attr-key", "attr-value2")
 
-            self.assertEqual(len(root.attributes), 7)
+            root.set_attribute("empty-list", [])
+            root.set_attribute("list-of-bools", [True, True, False])
+            root.set_attribute("list-of-numerics", [123, 3.14, 0])
+
+            self.assertEqual(len(root.attributes), 10)
             self.assertEqual(root.attributes["component"], "http")
             self.assertEqual(root.attributes["http.method"], "GET")
             self.assertEqual(
@@ -379,6 +383,9 @@ def test_attributes(self):
             self.assertEqual(root.attributes["http.status_text"], "OK")
             self.assertEqual(root.attributes["misc.pi"], 3.14)
             self.assertEqual(root.attributes["attr-key"], "attr-value2")
+            self.assertEqual(root.attributes["empty-list"], [])
+            self.assertEqual(root.attributes["list-of-bools"], [True, True, False])
+            self.assertEqual(root.attributes["list-of-numerics"], [123, 3.14, 0])
 
         attributes = {
             "attr-key": "val",
@@ -393,6 +400,18 @@ def test_attributes(self):
             self.assertEqual(root.attributes["attr-key2"], "val2")
             self.assertEqual(root.attributes["attr-in-both"], "span-attr")
 
+    def test_invalid_attribute_values(self):
+        class NonPrimitive:
+            pass
+
+        with self.tracer.start_as_current_span("root") as root:
+            root.set_attribute("non-primitive-data-type", NonPrimitive())
+            root.set_attribute("list-of-mixed-data-types-numeric-first", [123, False, "string"])
+            root.set_attribute("list-of-mixed-data-types-non-numeric-first", [False, 123, "string"])
+            root.set_attribute("list-with-non-primitive-data-type", [NonPrimitive(), 123])
+
+            self.assertEqual(len(root.attributes), 0)
+
     def test_sampling_attributes(self):
         decision_attributes = {
             "sampler-attr": "sample-val",