Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating network connection attributes names to latest in spec #350

Merged
merged 3 commits into from
Jan 7, 2020

Conversation

@hectorhdzg hectorhdzg requested a review from a team January 2, 2020 20:14
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one non-blocking question: is it worth updating the WSGI integration at the same time?

@hectorhdzg hectorhdzg changed the title Updating network connection attributes names to latest (pymongo) Updating network connection attributes names to latest in spec Jan 6, 2020
@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #350 into master will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
- Coverage   84.82%   84.77%   -0.06%     
==========================================
  Files          38       38              
  Lines        1839     1839              
  Branches      217      217              
==========================================
- Hits         1560     1559       -1     
  Misses        214      214              
- Partials       65       66       +1
Impacted Files Coverage Δ
...ry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py 68.18% <33.33%> (ø) ⬆️
...emetry-sdk/src/opentelemetry/sdk/trace/__init__.py 89.45% <0%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4458698...c07d9c2. Read the comment docs.

@hectorhdzg hectorhdzg added the PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jan 7, 2020
@toumorokoshi toumorokoshi merged commit a89bbc8 into open-telemetry:master Jan 7, 2020
@c24t c24t removed the PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jan 29, 2020
@hectorhdzg hectorhdzg deleted the hectorhdzg/pymongo branch March 24, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants